-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Misc Odyssey updates #2326
base: main
Are you sure you want to change the base?
Conversation
d22c240
to
e0dfc96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but i don't know what could break here either.
Does Applitools pass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved noting we'll be wrapping these. Sorry, I can't unapprove :/.
const Grid = ({ | ||
children, | ||
columns, | ||
component = "div", | ||
container, | ||
direction, | ||
item, | ||
rowSpacing, | ||
spacing, | ||
}: GridProps) => { | ||
return ( | ||
<MuiGrid | ||
columns={columns} | ||
container={container} | ||
component={component} | ||
direction={direction} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a Storybook entry for Grid
? I'm not sure I completely understand what it does without seeing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it's a direct port of a MUI component, I didn't think we'd want a story for it. What do you think?
const Stack = ({ children, spacing }: StackProps) => { | ||
return <MuiStack spacing={spacing}>{children}</MuiStack>; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the spacing stuff we're missing from Gen2? Can we get a Storybook entry for it?
OKTA-796463
Summary
Stack
andGrid
utility components from MUIgetOptionLabel
prop onAutocomplete
Testing & Screenshots