Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust datatable last column #2307

Merged
merged 10 commits into from
Aug 7, 2024
Merged

Conversation

jordankoschei-okta
Copy link
Contributor

image

  • When the table has resizable columns, but no actions, that last “phantom” column still displays
  • The resize handle is next to it… feels strange
  • Worse, it’s impossible to do anything with flex-grow in that second-to-last column because it will never fill the available space. That phantom column is always in the way.

Here's the solution:

  • IF there’s nothing in the action column && columns are resizable
  • THEN use display: none on that last column and force the second-to-last column to have flex-grow: 1, and hide the resize handle on the second-to-last column

@jordankoschei-okta jordankoschei-okta requested a review from a team as a code owner July 29, 2024 13:54
benlister-okta
benlister-okta previously approved these changes Aug 6, 2024
@oktapp-aperture-okta oktapp-aperture-okta bot merged commit 6b98b1d into main Aug 7, 2024
1 check passed
@oktapp-aperture-okta oktapp-aperture-okta bot deleted the jk-datatable-last-column branch August 7, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants