fix: adjust selector for close button

okta · Aug 14, 2024 · 73a3b09 · 73a3b09
1 parent 43907a9
commit 73a3b09
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/odyssey-react-mui/src/Banner.tsx b/packages/odyssey-react-mui/src/Banner.tsx
@@ -39,10 +39,13 @@ export const BannerTestSelectors = {
         templateVariableNames: ["linkText"],
       },
     },
-    close: {
+    closeButton: {
       selector: {
-        method: "ByLabelText",
-        text: "${labelText}",
+        method: "ByRole",
+        options: {
+          name: "${labelText}",
+        },
+        role: "button",
         templateVariableNames: ["labelText"],
       },
     },

diff --git a/packages/odyssey-storybook/src/components/odyssey-mui/Banner/Banner.stories.tsx b/packages/odyssey-storybook/src/components/odyssey-mui/Banner/Banner.stories.tsx
@@ -184,7 +184,7 @@ export const Dismissible: StoryObj<BannerProps> = {
         templateArgs: {
           role: "alert",
         },
-      }).select?.("close", {
+      }).select?.("closeButton", {
         labelText: "Close",
       }).element;