fix: addressing comments

okta · Aug 14, 2024 · 5b8acf7 · 5b8acf7
1 parent bfc362e
commit 5b8acf7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 18 deletions.
diff --git a/packages/odyssey-react-mui/src/Callout.tsx b/packages/odyssey-react-mui/src/Callout.tsx
@@ -37,21 +37,7 @@ export const CalloutTestSelectors = {
       },
     },
   },
-  //labels ? something that is a child of the selector rather than a separate feature
-  // text: {
-  //   selector: {
-  //     method: "ByText",
-  //     templateVariableNames: ["text"],
-  //     text: "${text}",
-  //   },
-  // },
-  // title: {
-  //   selector: {
-  //     method: "ByText",
-  //     templateVariableNames: ["title"],
-  //     text: "${title}",
-  //   },
-  // },
+  // label: ["description", "title"],
   selector: {
     method: "ByRole",
     options: {

diff --git a/packages/odyssey-react-mui/src/TextField.tsx b/packages/odyssey-react-mui/src/TextField.tsx
@@ -34,6 +34,7 @@ import { type FeatureTestSelector } from "./test-selectors";
 
 export const TextFieldTestSelectors = {
   feature: {
+    // label: ["errorMessage", "hint", "label"],
     description: {
       selector: {
         method: "ByText",

diff --git a/packages/odyssey-storybook/src/components/odyssey-mui/TextField/TextField.stories.tsx b/packages/odyssey-storybook/src/components/odyssey-mui/TextField/TextField.stories.tsx
@@ -248,7 +248,7 @@ export const Error: StoryObj<typeof TextField> = {
     defaultValue: "",
   },
   play: async ({ canvasElement, step }) => {
-    await step("has visible label", async () => {
+    await step("has visible error message", async () => {
       const element = queryOdysseySelector({
         canvas: within(canvasElement),
         componentName: "TextField",
@@ -269,7 +269,7 @@ export const ErrorsList: StoryObj<typeof TextField> = {
     defaultValue: "",
   },
   play: async ({ canvasElement, step }) => {
-    await step("has visible label", async () => {
+    await step("has visible error messages", async () => {
       const element = queryOdysseySelector({
         canvas: within(canvasElement),
         componentName: "TextField",
@@ -307,7 +307,7 @@ export const Hint: StoryObj<typeof TextField> = {
       }).element;
 
       expect(element).toHaveAccessibleDescription(
-        /Specify your destination within the Sol system./,
+        "Specify your destination within the Sol system.",
       );
     });
   },