This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
Adding Heroku team name as required parameter for create-heroku-app #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
cfnelson
approved these changes
Feb 7, 2018
There was a problem hiding this comment.
🔥 🌮 🎉 Worked on this with Chris, the original script wouldn't work when the project is created under a different team (e.g - clients team/project with own billing).
This was the solution we came up with and it worked nicely for us. It does mean that you will have to specify a team though from now on.
|
I actually don't think we need to use teams. There's a small maintenance advantage, maybe, but it costs more. |
|
On the other hand #53 already has teams throughout, so might as well stick with it I guess. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the
create-heroku-appto require a Heroku team name argument so apps will be created under the team for the client.