Updates from the world of Seam #34
Conversation
processes/development/new-app-setup/README.md processes/development/new-app-setup/semaphore-production-deploy-config processes/development/new-app-setup/semaphore-staging-deploy-config
ghost
requested review from
| # Copy production S3 data to staging | ||
|
|
||
| export AWS_ACCESS_KEY_ID=$AWS_ACCESS_KEY_ID | ||
| export AWS_SECRET_ACCESS_KEY=$AWS_SECRET_ACCESS_KEY |
There was a problem hiding this comment.
That was looking a bit redundant. 😀
| npm install | ||
| npm --version | ||
| node --version | ||
| exp --version |
There was a problem hiding this comment.
Would we want these three xx --version lines for the production deploy too? I realize they aren't necessary but they're helpful for debugging.
| npm install | ||
| npm --version | ||
| node --version | ||
| exp --version |
There was a problem hiding this comment.
Would we want these three xx --version lines for the production deploy too? I realize they aren't necessary but they're helpful for debugging.
There was a problem hiding this comment.
@ccuilla Sorry, I thought I left a review but I ended up leaving a comment. I wanted to know if the semaphore build script should mention that it's only for mobile? As we don't keep a web folder if only creating a web app.
Hopefully when you are back we can finish/polish this off and get it merged. It looks very detailed. 👍
| cp /home/runner/settings.json settings.json | ||
| meteor npm run lint | ||
| meteor npm run unit-test | ||
| npm install -g exp |
There was a problem hiding this comment.
@ccuilla Shouldn't we split the script out for web and mobile builds? Or did I mistakenly miss where the guide says this is only for mobile builds?
| 1. `meteor --version` | ||
| 1. `meteor npm install` | ||
| 1. `meteor npm start` _wip: find and add instructions to listen for success and exit process_ | ||
| 1. Set the Node version to node.js 7.10.1 (or later) |
There was a problem hiding this comment.
As of Meteor 1.6, can we change this to 8.7.x now?
processes/development/new-app-setup/README.md
processes/development/new-app-setup/semaphore-production-deploy-config
processes/development/new-app-setup/semaphore-staging-deploy-config