Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Improve CI setup instructions #23

Merged
merged 1 commit into from
Mar 21, 2017
Merged

Improve CI setup instructions #23

merged 1 commit into from
Mar 21, 2017

Conversation

tsemana
Copy link
Contributor

@tsemana tsemana commented Mar 21, 2017

Based on findings in Rapunzl CI setup

@cfnelson cfnelson self-requested a review March 21, 2017 19:04
Copy link
Contributor

@cfnelson cfnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

1. `npm install`
1. `cp settings.json.example settings.json`
1. `meteor npm install`
1. `meteor npm start` _wip: find and add instructions to listen for success and exit process_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might need to use meteor test --once - but this would require a meteor integration test package, I think. https://guide.meteor.com/testing.html#command-line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdickert I'll play around with it in SSH. If anything, I think I should be able run the chimp smoke test. But I think the test structure needs to be fixed (it's breaking with the unit&integration tests)

@tsemana tsemana merged commit 0662594 into master Mar 21, 2017
@xavxyz xavxyz deleted the ci-guides-update branch January 12, 2018 08:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants