This repository has been archived by the owner on Feb 28, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 61
Importing and serializing company data #263
Open
Ilozuluchris
wants to merge
19
commits into
okfn-brasil:master
Choose a base branch
from
Ilozuluchris:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
3c98772
testing to see if it works
Ilozuluchris d8ddaac
removed unnecessary import statement
Ilozuluchris 055ee86
Importing companies data with rows library
Ilozuluchris f14a1e9
some final changes
Ilozuluchris b4b65ea
Finished with companies data
Ilozuluchris c28bb54
fixup! Finished with companies data
Ilozuluchris 8a4bc18
Applied suggestions
Ilozuluchris ceaf203
Added rows to requirements.txt
Ilozuluchris 383e578
Removed test for the serialize method(since it does not exist any mor…
Ilozuluchris 422dd04
fixup! Removed test for the serialize method(since it does not exist …
Ilozuluchris b3f4e9b
Removed patch decorator for csv.DictReader
Ilozuluchris 6070f7c
Removed serialize.return_value
Ilozuluchris 57acdf6
Merge branch 'master' into master
Ilozuluchris a221cd5
Merge branch 'master' into master
cuducos 662652b
Trying to fix positional argument issue
Ilozuluchris 1050063
Issue with reading file with rows
Ilozuluchris 6424c0a
Got test to work
Ilozuluchris 94bdd5d
Using a dictionary in assertion of the create mocked object
Ilozuluchris be4513c
reformatted some necessary dictionaries
Ilozuluchris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a contant, could you named it with caps (i.e.
COMPANIES_CSV_FIELDS
) and put it before theclass
definition (just after the imports)?Also, in Python we use one of these formatting styles:
Or:
Also, can you reflect this formatting decision in
arbas/core/tests/test_companies_command.py
(line 46), isting one field per line?