Improve map and map-ref.
#209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okamsn
force-pushed
the
map-step-uniq
branch
from
534b058
to
5da35ed
Compare
- Check as we go instead of using `seq-uniq` immediately, which tests have shown to always faster for the tested 10, 100, and 1000 entries. - Allow `unique` to be evaluated at run time. Optimize when we know when it is `nil` or `non-nil` at compile time. - Clarify Org docs.
okamsn
force-pushed
the
map-step-uniq
branch
from
5da35ed
to
6c9e431
Compare
github-actions bot
added a commit
that referenced
this pull request
Sep 11, 2024
This commit was copied from the master branch. Commit: 64a95bc Author: okamsn <[email protected]> Date: 2024-09-11 23:05:21 +0000 Improve `map` and `map-ref`. (#209) - Check as we go instead of using `seq-uniq` immediately, which tests have shown to always faster for the tested 10, 100, and 1000 entries. - Allow `unique` to be evaluated at run time. Optimize when we know when it is `nil` or `non-nil` at compile time. - Clarify Org docs. See also issue #179. Closes #179.
github-actions bot
added a commit
that referenced
this pull request
Sep 11, 2024
This commit was copied from the master branch. Commit: 64a95bc Author: okamsn <[email protected]> Date: 2024-09-11 23:05:21 +0000 Improve `map` and `map-ref`. (#209) - Check as we go instead of using `seq-uniq` immediately, which tests have shown to always faster for the tested 10, 100, and 1000 entries. - Allow `unique` to be evaluated at run time. Optimize when we know when it is `nil` or `non-nil` at compile time. - Clarify Org docs. See also issue #179. Closes #179.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check as we go instead of using
seq-uniqimmediately, which tests have shownto always faster for the tested 10, 100, and 1000 entries.
Allow
uniqueto be evaluated at run time. Optimize when we knowwhen it is
nilornon-nilat compile time.Clarify Org docs.