Make always, never, and thereis like other accumulation commands.
#197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okamsn
force-pushed
the
accum-always-never-thereis
branch
2 times, most recently
from
d5ea979
to
f195556
Compare
Closes #145. - Limit the commands to only one condition. - Implement the commands using `loopy--defaccumulation`. - Correct the documentation string of `loopy-result` to mention the boolean commands. - Fix errors in tests `custom-command-always-pass` and `custom-command-always-fail`. These tests were accidentally running the built-in `always` command, not the tested version.
okamsn
force-pushed
the
accum-always-never-thereis
branch
from
f195556
to
6a92682
Compare
github-actions bot
added a commit
that referenced
this pull request
Mar 10, 2024
…ulation commands. (#197) This commit was copied from the master branch. Commit: de9a293 Author: okamsn <[email protected]> Date: 2024-03-10 00:50:44 +0000 Make `always`, `never`, and `thereis` more like accumulation commands. (#197) Closes #145. Make the signatures of the commands be `(command [VAR] CONDITION &key into)`. - Limit the commands to only one condition. - Implement the commands using `loopy--defaccumulation`. - Correct the documentation string of `loopy-result` to mention the boolean commands. - Update the Org documentation. - Fix errors in tests `custom-command-always-pass` and `custom-command-always-fail`. These tests were accidentally running the built-in `always` command, not the tested version.
github-actions bot
added a commit
that referenced
this pull request
Mar 10, 2024
…ulation commands. (#197) This commit was copied from the master branch. Commit: de9a293 Author: okamsn <[email protected]> Date: 2024-03-10 00:50:44 +0000 Make `always`, `never`, and `thereis` more like accumulation commands. (#197) Closes #145. Make the signatures of the commands be `(command [VAR] CONDITION &key into)`. - Limit the commands to only one condition. - Implement the commands using `loopy--defaccumulation`. - Correct the documentation string of `loopy-result` to mention the boolean commands. - Update the Org documentation. - Fix errors in tests `custom-command-always-pass` and `custom-command-always-fail`. These tests were accidentally running the built-in `always` command, not the tested version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145.
loopy--defaccumulation.loopy-resultto mention the booleancommands.
custom-command-always-passandcustom-command-always-fail. These tests were accidentally runningthe built-in
alwayscommand, not the tested version.