Fix find.
#171
Merged
Fix find.
#171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix `:on-failure` when the accumulated value is set to nil. Previously, a nil value was interpreted a failing the test, which meant that the value `:on-failure` would be used. - Fix detecting `:on-failure` when the keyword value is nil. Previously, if the value given by `:on-failure` was nil, then that would be interpreted as the keyword not being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nilafter passing the test.
:on-failureeven when the value is explicitlynil. If the testsfails, the accumulation variable should still be set to
nilin case it hassome other value at the time of failing.