Create stack-based accumulation commands #107
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for arrays.
We use this function in the expansion of the `drop-while` command.
This makes working with some functional features much easier. Other packages require this, so it is fine if we do as well.
…ences. We could use `seq-subseq`, but being more explicit allows us to avoid dependencies and having to check types during each iteration of the loop.
This uses more basic features, but the code generation should be split into several functions at this point.
For stack commands, which are handled during the third pass, we should be able to tell if end-tracking is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #103.
We require that only accumulation commands can edit the variable. While we do
have generic commands like
reduceandaccumulate, it would still beconvenient to have others.
Possible candidates:
(drop VAR N :at POS)with aliaspop.posdefaults tostart.(drop-while VAR COND)with aliaspop-whiletakefor the opposite ofdroptake-whilefor the opposite ofdrop-whilediffordifferencefor an operation likeseq-differenceFor now, we've decided to have the commands initialize variables and their
preferred positions for optimization.
TODO: Should the
*-whilecommands support expressions, as infind?For example, should
(drop-while VAR EXPR)(as opposed to(drop-while VAR PRED)be equivalent to the following? While the alternative is wordy, is theoperation that common?
(subloop (without VAR) (while EXPR) (drop VAR 1))