Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make always, never, and thereis consistent with other commands. #145

Closed
okamsn opened this issue Jan 12, 2023 · 0 comments · Fixed by #197
Closed

Make always, never, and thereis consistent with other commands. #145

okamsn opened this issue Jan 12, 2023 · 0 comments · Fixed by #197
Labels
breaking changes deprecation/obsoletion Marking things for eventual removal simplification Making things simpler

Comments

@okamsn
Copy link
Owner

okamsn commented Jan 12, 2023

Currently, these commands do not take a variable name as an optional first argument. Instead, they take multiple conditions, and these conditions are and-ed or or-ed depending on the command. If a user wants even slightly different behavior, then they must fallback to passing a single condition. The passing of a single condition is expected behavior.

However, to change the the target variable, the user can only use :into (adding in #144) and cannot specify a variable as the first argument. This is a break in convention with other similar commands.

Because it is no hard thing to pass only a single condition, and because it is a harder thing to remember that these commands are called differently than dozens of others, it is better to change the boolean commands to have a consistent convention with the iteration and accumulation commands.
@okamsn okamsn added breaking changes deprecation/obsoletion Marking things for eventual removal simplification Making things simpler labels Jan 12, 2023
@okamsn okamsn mentioned this issue Feb 4, 2023
Closed
7 tasks
okamsn added a commit that referenced this issue Aug 12, 2023
@okamsn
Warn that always, never, and thereis should not use multiple co…
acd9c2d 
…nditions.

These commands will be changed to have function signatures more like
accumulation commands, with an optional initial `VAR` argument.

- Update the commands to `warn`.
- Update the Org document and Texinfo file.

This is tracked in #145.
@okamsn okamsn mentioned this issue Aug 12, 2023
Merged
okamsn added a commit that referenced this issue Aug 12, 2023
@okamsn
Warn that always, never, and thereis should not use multiple co…
270c2bf 
…nditions. (#161)

These commands will be changed to have function signatures more like
accumulation commands, with an optional initial `VAR` argument.

- Update the commands to `warn`.
- Update the Org document and Texinfo file.

This is tracked in #145.
okamsn added a commit that referenced this issue Mar 10, 2024
@okamsn
Make always, never, and thereis like other accumulation commands.
4526d6f 
Closes #145.

- Limit the commands to only one condition.
- Implement the commands using `loopy--defaccumulation`.
- Correct the documentation string of `loopy-result` to mention the boolean
  commands.
okamsn added a commit that referenced this issue Mar 10, 2024
@okamsn
Make always, never, and thereis like other accumulation commands.
f80015b 
Closes #145.

- Limit the commands to only one condition.
- Implement the commands using `loopy--defaccumulation`.
- Correct the documentation string of `loopy-result` to mention the boolean
  commands.
- Fix errors in tests `custom-command-always-pass` and
  `custom-command-always-fail`.  These tests were accidentally running
  the built-in `always` command, not the tested version.
@okamsn okamsn mentioned this issue Mar 10, 2024
Merged
okamsn added a commit that referenced this issue Mar 10, 2024
@okamsn
Make always, never, and thereis like other accumulation commands.
d5ea979 
Closes #145.

- Limit the commands to only one condition.
- Implement the commands using `loopy--defaccumulation`.
- Correct the documentation string of `loopy-result` to mention the boolean
  commands.
- Fix errors in tests `custom-command-always-pass` and
  `custom-command-always-fail`.  These tests were accidentally running
  the built-in `always` command, not the tested version.
okamsn added a commit that referenced this issue Mar 10, 2024
@okamsn
Make always, never, and thereis like other accumulation commands.
f195556 
Closes #145.

- Limit the commands to only one condition.
- Implement the commands using `loopy--defaccumulation`.
- Correct the documentation string of `loopy-result` to mention the boolean
  commands.
- Fix errors in tests `custom-command-always-pass` and
  `custom-command-always-fail`.  These tests were accidentally running
  the built-in `always` command, not the tested version.
okamsn added a commit that referenced this issue Mar 10, 2024
@okamsn
Make always, never, and thereis like other accumulation commands.
6a92682 
Closes #145.

- Limit the commands to only one condition.
- Implement the commands using `loopy--defaccumulation`.
- Correct the documentation string of `loopy-result` to mention the boolean
  commands.
- Fix errors in tests `custom-command-always-pass` and
  `custom-command-always-fail`.  These tests were accidentally running
  the built-in `always` command, not the tested version.
okamsn added a commit that referenced this issue Mar 10, 2024
@okamsn
Make always, never, and thereis more like accumulation commands. (
de9a293 
#197)

Closes #145.

Make the signatures of the commands be `(command [VAR] CONDITION &key into)`.

- Limit the commands to only one condition.
- Implement the commands using `loopy--defaccumulation`.
- Correct the documentation string of `loopy-result` to mention the boolean
  commands.
- Update the Org documentation.
- Fix errors in tests `custom-command-always-pass` and
  `custom-command-always-fail`.  These tests were accidentally running
  the built-in `always` command, not the tested version.
github-actions bot added a commit that referenced this issue Mar 10, 2024
@github-actions
(GitHub Action) Make always, never, and thereis more like accum…
77e2a79 
…ulation commands. (#197)

This commit was copied from the master branch.

Commit: de9a293
Author: okamsn <[email protected]>
Date: 2024-03-10 00:50:44 +0000

Make `always`, `never`, and `thereis` more like accumulation commands. (#197)

Closes #145.

Make the signatures of the commands be `(command [VAR] CONDITION &key into)`.

- Limit the commands to only one condition.
- Implement the commands using `loopy--defaccumulation`.
- Correct the documentation string of `loopy-result` to mention the boolean
  commands.
- Update the Org documentation.
- Fix errors in tests `custom-command-always-pass` and
  `custom-command-always-fail`.  These tests were accidentally running
  the built-in `always` command, not the tested version.
github-actions bot added a commit that referenced this issue Mar 10, 2024
@github-actions
(GitHub Action) Make always, never, and thereis more like accum…
aee76c0 
…ulation commands. (#197)

This commit was copied from the master branch.

Commit: de9a293
Author: okamsn <[email protected]>
Date: 2024-03-10 00:50:44 +0000

Make `always`, `never`, and `thereis` more like accumulation commands. (#197)

Closes #145.

Make the signatures of the commands be `(command [VAR] CONDITION &key into)`.

- Limit the commands to only one condition.
- Implement the commands using `loopy--defaccumulation`.
- Correct the documentation string of `loopy-result` to mention the boolean
  commands.
- Update the Org documentation.
- Fix errors in tests `custom-command-always-pass` and
  `custom-command-always-fail`.  These tests were accidentally running
  the built-in `always` command, not the tested version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking changes deprecation/obsoletion Marking things for eventual removal simplification Making things simpler
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make always, never, and thereis like other accumulation commands. okamsn/loopy
1 participant
@okamsn