Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assembling of simple valid non-object or non-array Json strings #16

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

tveeders
Copy link
Contributor

No description provided.

@tveeders
Copy link
Contributor Author

The idea is to also allow parsing of simple valid JSON strings which are not wrapped in an object or array.
In the current implementation the Json sink is never invoked which leads to blocked resources (and timeouts) if the client does respond with just numbers, enum values etc.

By invoking the sink.accept function whenever a token was processed and the depth is 0 we also make sure simple JSON strings can be processed.

@ok2c ok2c merged commit f06cdea into ok2c:master Jun 10, 2024
1 check passed
@ok2c
Copy link
Owner

ok2c commented Jun 10, 2024

@tveeders Good catch! Thank you for contributing the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants