Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fasta support for load_genomic_breaks() function #31

Merged
merged 2 commits into from
Jul 25, 2024
Merged

add fasta support for load_genomic_breaks() function #31

merged 2 commits into from
Jul 25, 2024

Conversation

johannesnicolaus
Copy link
Contributor

This update adds functionality to load fasta instead of BSgenome objects, while maintaining the arguments for backwards compatibility

charles-plessy
charles-plessy requested changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@charles-plessy charles-plessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think I found a typo, though.

R/load_genomic_breaks.R Outdated Show resolved Hide resolved
@johannesnicolaus
Copy link
Contributor Author

Fixed the typo. Should be OK now.

@charles-plessy charles-plessy merged commit 1acf300 into oist:main Jul 25, 2024
1 check passed
@charles-plessy
Copy link
Collaborator

Just pushed it in version 0.14.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-plessy charles-plessy charles-plessy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johannesnicolaus @charles-plessy