fix: Move commonVars initialization to state-modifying methods #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Initialize commonVars in state-modifying methods (optimize, constructor, setRadicand) - Fix template resolution in Sum.cpp by using explicit iterator type - Add documentation for commonVars initialization
ohhmm
force-pushed
the
fix/commonvars-initialization
branch
from
ea3be01
to
5a259db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes template resolution errors by properly initializing commonVars in state-modifying methods.
Changes:
Link to Devin run: https://preview.devin.ai/devin/6bf0364593964fbb818f12d0959d5c5c
If you have any feedback, you can leave comments in the PR and I'll address them in the app!