Fix Sum::operator+= and SumOrderComparator #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
devin-ai-integration
bot
force-pushed
the
fix/sum-operator-plus-equals
branch
from
8937002
to
ec5d483
Compare
ohhmm
force-pushed
the
fix/sum-operator-plus-equals
branch
3 times, most recently
from
1b52f38
to
725b50b
Compare
- Add strict floating-point behavior flags for macOS builds - Disable aggressive floating-point optimizations - Add optimization calls in test_extrapolator for numerical stability - Add warnings for floating-point comparisons and promotions Add optimization calls for numerical stability in test_extrapolator.cpp - Add optimize() before subsystem multiplication - Add optimize() before formula evaluation - Add optimize() before equation testing - Add optimize() before formula comparison in Codec_test - Ensure consistent numerical behavior on macOS fix: Replace unsafe floating-point comparison with epsilon-based comparison using boost::multiprecision fix: Use cpp_rational for precise comparison in Integer.cpp Add numerical stability optimizations in test_extrapolator.cpp - Add optimization calls before critical operations - Enhance numerical stability in ViewMatrix_test - Add optimization before matrix operations and comparisons - Ensure consistent optimization strategy in Codec_test - Double optimization passes for stability-critical operations fix: Use boost::multiprecision::cpp_dec_float_100 for safe floating-point comparison in Valuable::operator< fix: Use boost::multiprecision epsilon-based comparison for safe floating-point comparison in Valuable::operator< fix: Implement proper floating-point comparison in Valuable using Fraction fix: Implement stable floating-point comparison in Valuable.cpp perf: Optimize test_extrapolator.cpp to reduce redundant optimization calls fix: modify optimize() to return Valuable& for method chaining fix: Update optimize() methods to return Valuable& and fix empty returns fix: Update ANTILOOP and DUO_OPT_PFX macros to return *this fix: Update optimize() methods to consistently return Valuable& fix: Update optimize() methods in Modulo and PrincipalSurd to return Valuable& fix: Update CHECK_OPTIMIZATION_CACHE macro to return *this fix: Add missing return *this in Sum::optimize() revert: Undo changes to CHECK_OPTIMIZATION_CACHE and Sum::optimize() that caused test failures
ohhmm
force-pushed
the
fix/sum-operator-plus-equals
branch
from
725b50b
to
ab619b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed issues with Sum::operator+= and SumOrderComparator:
Testing
Link to Devin run: https://preview.devin.ai/devin/066f703943b349adbffedc19e29367a5
If you have any feedback, you can leave comments in the PR and I'll address them in the app!