Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable image_codec_test with valid test data #413

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Oct 30, 2024

Changes

  • Replace corrupted TGA test files with valid 2x2 and 4x4 RGBA test images
  • Add test image generator script for reproducibility
  • Enable image_codec_test across all CI workflows
  • Remove image_codec_test from test exclusion patterns while keeping ts exclusion

Testing

The changes include:

  1. Valid test images with known patterns
  2. Python script to regenerate test images if needed
  3. Enabled test across all platforms

Link to Devin run

https://preview.devin.ai/devin/3cf1b9c0450b465ab403fb42818060ad

Please review the changes and let me know if any adjustments are needed.

If you have any feedback, you can leave comments in the PR and I'll address them in the app!

- Replace corrupted TGA test files with valid 2x2 and 4x4 RGBA test images
- Add test image generator script for reproducibility
- Test images contain known patterns for verification
- Remove image_codec_test from test exclusion patterns
- Keep ts test exclusion for stability
- Enable test across all platforms (Ubuntu, macOS, Windows)
- Enable ASAN for Debug build configuration
- Set CMAKE_BUILD_TYPE=Debug for better debugging information
- Keep Release build for performance comparison
@ohhmm ohhmm force-pushed the fix/enable-image-codec-test branch from c19d39a to efe1476 Compare November 8, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants