Fix : Cancelled requests in appointments page and Remove files button from actions #10219
Conversation
WalkthroughThe pull request introduces two main changes: first, adding tooltip functionality to the Changes
Assessment against linked issues
Possibly related PRs
Suggested Labels
Suggested Reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Mahendar0701
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/components/Patient/PatientHome.tsx (2)
171-186: Consider increasing the tooltip delay duration.The tooltip implementation is good, but a 1ms delay might cause unintended tooltip flickers during mouse movement. Consider increasing
delayDurationto a more standard value (e.g., 200-300ms) for better UX.- <TooltipProvider delayDuration={1}> + <TooltipProvider delayDuration={200}>
199-214: Consider extracting a reusable date tooltip component.The tooltip implementation is duplicated between modified and created dates. Consider extracting this into a reusable component to improve maintainability and reduce code duplication.
Example implementation:
const DateTooltip = ({ date }: { date: string | null }) => ( <TooltipProvider delayDuration={200}> <Tooltip> <TooltipTrigger asChild> <span> {date ? relativeDate(date) : "--:--"} </span> </TooltipTrigger> <TooltipContent> {date ? formatDateTime(date) : "--:--"} </TooltipContent> </Tooltip> </TooltipProvider> );Usage:
- <TooltipProvider delayDuration={1}> - <Tooltip> - <TooltipTrigger asChild> - <span> - {patientData.created_date - ? relativeDate(patientData.created_date) - : "--:--"} - </span> - </TooltipTrigger> - <TooltipContent> - {patientData.created_date - ? formatDateTime(patientData.created_date) - : "--:--"} - </TooltipContent> - </Tooltip> - </TooltipProvider> + <DateTooltip date={patientData.created_date} />
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/components/Patient/PatientHome.tsx(3 hunks)src/pages/Appointments/AppointmentsPage.tsx(2 hunks)
🔇 Additional comments (3)
src/components/Patient/PatientHome.tsx (1)
8-13: LGTM!The tooltip component imports are correctly structured and properly utilized in the implementation.
src/pages/Appointments/AppointmentsPage.tsx (2)
669-669: LGTM! Good performance optimization.The use of
query.debouncedis a good optimization that will help reduce unnecessary API calls during rapid parameter changes.
778-778: LGTM! Consistent implementation.The use of
query.debouncedis consistent with the implementation in AppointmentColumn, maintaining a uniform approach to API call optimization.
| queryFn: query(scheduleApis.appointments.list, { | ||
| queryFn: query.debounced(scheduleApis.appointments.list, { |
There was a problem hiding this comment.
this is not the right solution. this just hides the root cause of firing duplicate issues by leveraging cancellations. let's solve the root issue instead of solving the side-effect.
There was a problem hiding this comment.
The root cause here is , qParams are not loaded on initially render, later qParams are fully loaded and then the query is being triggered again and causing cancelling of previous queries. This is happening only on initial visit of encounter tab.
const isQParamsLoaded = Object.keys(qParams).length > 0;
if (!isQParamsLoaded || schedulableUsersQuery.isLoading) {
return <Loading />;
}- Adding query.debounced
Which approach you will prefer??
rithviknishad
added
invalid
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
New Features
Improvements