Minor fixes in resource creation form #10218

Rishith25 · 2025-01-27T16:25:35Z

Proposed Changes

Fixes Minor fixes in resource creation form #9866
To display the patient name in resource creation form
Instead of facility ID , facilityname should be visible in breadcrumbs

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Enhanced patient data handling in resource creation.
- Added ability to link and display patient information.
UI Updates
- Replaced existing form fields with new input components.
- Added navigation link to patient demographic page.

coderabbitai · 2025-01-27T16:25:44Z

Walkthrough

The pull request modifies the ResourceCreate.tsx component to improve patient data handling and update UI components. The changes include simplifying the queryFn for facility data, adding a new useQuery hook to fetch patient information based on a query parameter, and replacing existing form input components with new Input and Textarea components. The modifications enhance the resource creation process by providing more dynamic patient linking and updating the input field implementations.

Changes

File	Change Summary
`src/components/Resource/ResourceCreate.tsx`	- Imported `Link`, `Input`, and `Textarea` components - Simplified `queryFn` for facility data retrieval - Added new `useQuery` hook for patient data - Updated patient information display logic - Replaced `TextFormField` and `TextAreaFormField` with new input components

Assessment against linked issues

Objective	Addressed	Explanation
Replace deprecated form components with shadcn ui components	✅
Instead of patient id, show patient name and add a link	✅
Resource request form submission	❓	Partial changes observed, full submission validation unclear
Resources display in board view	❓	No direct changes to board view implementation visible
Sub-category error resolution	❓	No explicit sub-category error handling evident

Possibly related PRs

Add 'Update Details' Button in Community Nurse Log Update Details Page #9094: Shared navigation enhancements with Link component
Fix: Duplicate network requests in Patient Details page #9297: Similar patient data fetching logic
Fix: Overflow for switchers in sidebar, Avatar size in notes tab, Textbox expansion in Add Facility #10005: UI component updates in resource-related components

Suggested labels

needs review, tested

Suggested reviewers

rithviknishad
Jacobjeevan

Poem

🐰 A rabbit's tale of code so bright,
Resources dancing with patient's might,
Inputs refined, queries clean and neat,
A component's journey, now complete!
Hop, hop, hooray for clean design! 🚀

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c131b2e and f32c12e.

📒 Files selected for processing (1)

src/components/Resource/ResourceCreate.tsx (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/components/Resource/ResourceCreate.tsx

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: cypress-run (1)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-01-27T16:25:55Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`f32c12e`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/679ab81fb2c8f80008529a87
😎 Deploy Preview	https://deploy-preview-10218--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/Resource/ResourceCreate.tsx (1)
202-218: Consider adding ARIA label for better accessibility.

The patient link implementation looks great! Consider adding an aria-label to improve accessibility for screen readers.
 <Link
   href={`/facility/${facilityId}/patient/${related_patient}/demography`}
+  aria-label={t("view_patient_details", { name: patientData.name })}
 >

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a481488 and 5dff94b.

📒 Files selected for processing (1)

src/components/Resource/ResourceCreate.tsx (8 hunks)

🔇 Additional comments (4)

src/components/Resource/ResourceCreate.tsx (4)

24-24: LGTM! Import changes align with component updates.

The new imports from the UI library support the migration from deprecated form components to standardized ones.

Also applies to: 34-34

106-108: LGTM! Query function simplified.

The removal of the arrow function wrapper improves code clarity without changing functionality.

112-118: LGTM! Patient data query implementation.

The query is well-implemented with:

Proper key structure for caching

Conditional enabling based on parameter existence

Correct path parameter handling

346-349: LGTM! Form components successfully migrated.

The deprecated form components have been successfully replaced with the new UI components while maintaining all functionality and translations.

Also applies to: 366-369, 412-412

github-actions · 2025-01-28T09:11:31Z

👋 Hi, @Rishith25,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Jacobjeevan · 2025-01-29T06:29:36Z

LGTM, but which deprecated components are being replaced 🤔

Rishith25 · 2025-01-29T06:34:53Z

LGTM, but which deprecated components are being replaced 🤔

@Jacobjeevan It got replaced in PR #10214. I have to change the description of the issue

…care_fe into resource-request-form

nihal467 · 2025-01-29T18:27:03Z

fix the redirection of resources in the breadcrumbs along with this PR

Rishith25 · 2025-01-30T00:40:26Z

@nihal467 Done the changes

minor fixes in resource creation

5dff94b

Rishith25 requested a review from a team as a code owner January 27, 2025 16:25

github-actions bot added the Deploy-Failed Deplyment is not showing preview label Jan 27, 2025

coderabbitai bot reviewed Jan 27, 2025

View reviewed changes

trigger

6abf479

github-actions bot added the merge conflict pull requests with merge conflict label Jan 28, 2025

Merge branch 'develop' into resource-request-form

5631c50

github-actions bot removed the merge conflict pull requests with merge conflict label Jan 28, 2025

Jacobjeevan approved these changes Jan 29, 2025

View reviewed changes

Jacobjeevan added needs testing needs review labels Jan 29, 2025

Rishith25 and others added 4 commits January 29, 2025 12:08

Merge branch 'develop' into resource-request-form

8eaea75

Merge branch 'develop' into resource-request-form

f1cb434

changes

d0fca5b

Merge branch 'resource-request-form' of https://github.com/Rishith25/…

c131b2e

…care_fe into resource-request-form

nihal467 removed the Deploy-Failed Deplyment is not showing preview label Jan 29, 2025

nihal467 added changes required and removed needs testing needs review labels Jan 29, 2025

resource breadcrumbs uri changed

f32c12e

Rishith25 requested a review from Jacobjeevan January 29, 2025 23:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minor fixes in resource creation form #10218

Minor fixes in resource creation form #10218

Rishith25 commented Jan 27, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 27, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Jan 27, 2025 •

edited

Loading

coderabbitai bot left a comment

github-actions bot commented Jan 28, 2025

Jacobjeevan commented Jan 29, 2025

Rishith25 commented Jan 29, 2025

nihal467 commented Jan 29, 2025

Rishith25 commented Jan 30, 2025

Minor fixes in resource creation form #10218

Are you sure you want to change the base?

Minor fixes in resource creation form #10218

Conversation

Rishith25 commented Jan 27, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

Summary by CodeRabbit

coderabbitai bot commented Jan 27, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 27, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 28, 2025

Jacobjeevan commented Jan 29, 2025

Rishith25 commented Jan 29, 2025

nihal467 commented Jan 29, 2025

Rishith25 commented Jan 30, 2025

Rishith25 commented Jan 27, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jan 27, 2025 •

edited

Loading