Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid cancelled calls in appointments page | Remove view files from action section #10192

Closed
2 tasks done
Mahendar0701 opened this issue Jan 25, 2025 · 4 comments · Fixed by #10219
Closed
2 tasks done

Avoid cancelled calls in appointments page | Remove view files from action section #10192

Mahendar0701 opened this issue Jan 25, 2025 · 4 comments · Fixed by #10219
Assignees
@Mahendar0701
Labels
work-in-progress

Comments

@Mahendar0701
Copy link
Contributor

Mahendar0701 commented Jan 25, 2025 •
edited
Loading

  • 1) When appointments page is visited then initially api calls are cancelling which can be prevented if we use query.debounced

Image

  • 2) Remove view patients files button from action section because we already have files tab. This is redundant

Image
@Mahendar0701
Copy link
Contributor Author

@rithviknishad @Jacobjeevan i want to work on this, assign this to me

@Mahendar0701 Mahendar0701 changed the title Add query.debounced in appointments page | Remove view files from action section | Incorrect icons for message length Add query.debounced in appointments page | Remove view files from action section | Incorrect icon for messages count Jan 25, 2025
@rajku-dev
Copy link
Contributor

rajku-dev commented Jan 25, 2025 •
edited
Loading

third one is fixed in #10156

@Jacobjeevan
Copy link
Contributor

Jacobjeevan commented Jan 27, 2025 •
edited
Loading

(1) Investigate why the issue is happening first (if it's an issue, since I can't reproduce this on Firefox).

@Jacobjeevan Jacobjeevan added this to Care Jan 27, 2025
@github-project-automation github-project-automation bot moved this to Triage in Care Jan 27, 2025
@Jacobjeevan Jacobjeevan moved this from Triage to Up Next in Care Jan 27, 2025
@Mahendar0701
Copy link
Contributor Author

Mahendar0701 commented Jan 27, 2025 •
edited
Loading

@Jacobjeevan on initial render some props are not populated completely and it is causing api request to cancel.

Image

in firefox also requests are cancelling

@Mahendar0701 Mahendar0701 mentioned this issue Jan 27, 2025
Merged
6 tasks
@Mahendar0701 Mahendar0701 changed the title Add query.debounced in appointments page | Remove view files from action section | Incorrect icon for messages count Add query.debounced in appointments page | Remove view files from action section Jan 30, 2025
@Mahendar0701 Mahendar0701 changed the title Add query.debounced in appointments page | Remove view files from action section Avoid cancelled calls in appointments page | Remove view files from action section Feb 3, 2025
@github-project-automation github-project-automation bot moved this from Up Next to Done in Care Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mahendar0701 Mahendar0701

Labels
work-in-progress
Projects
Care
Status: Done
Milestone
No milestone
3 participants
@Jacobjeevan @Mahendar0701 @rajku-dev