Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements in Encounter Discussion #9842

Open
rajku-dev opened this issue Jan 8, 2025 · 10 comments · May be fixed by #10156
Open

Enhancements in Encounter Discussion #9842

rajku-dev opened this issue Jan 8, 2025 · 10 comments · May be fixed by #10156
Assignees
@rajku-dev
Labels
work-in-progress

Comments

@rajku-dev
Copy link
Contributor

rajku-dev commented Jan 8, 2025 •
edited
Loading

  • Message expects a profile URL or avatar link to navigate to user profile
    link to

  • Each message should be labeled with a timestamp indicating when it was sent or received. (backend provides it)

  • If this number is used to display the number of users participated in thread, then it needs to be fixed, and next to it we can show number of messages (can be derived from existing backend response)
  • Duplicate thread name - labelling them by slicing their provided ids
@rajku-dev
Copy link
Contributor Author

rajku-dev commented Jan 8, 2025 •
edited
Loading

If a subset of these changes are applicable, then I would like to take on this task.
@rithviknishad @Jacobjeevan

@rajku-dev rajku-dev changed the title Improvements in Encounter Discussion/Chat Enhancements in Encounter Discussion/Chat Jan 8, 2025
@kris70lesgo
Copy link

hey @rajku-dev are u working on this issue ?

@github-actions github-actions bot added needs-triage question Further information is requested labels Jan 9, 2025
@rajku-dev
Copy link
Contributor Author

hey @rajku-dev are u working on this issue ?

yup! but i can only make a PR once i'm assigned this issue.

@rajku-dev rajku-dev mentioned this issue Jan 13, 2025
Open
3 tasks
@rajku-dev
Copy link
Contributor Author

rajku-dev commented Jan 21, 2025 •
edited
Loading

Hi @Jacobjeevan , can i work on this
I have made some changes including adding link for user-profile using raviger, and time for message

@rajku-dev rajku-dev changed the title Enhancements in Encounter Discussion/Chat Enhancements in Encounter Discussion Jan 22, 2025
@Jacobjeevan Jacobjeevan removed question Further information is requested needs-triage labels Jan 24, 2025
@Jacobjeevan
Copy link
Contributor

@rajku-dev Assigned.

Since the other PR is still open, avoid replicating the work mentioned in the other issue.

@rajku-dev
Copy link
Contributor Author

@rajku-dev Assigned.

Since the other PR is still open, avoid replicating the work mentioned in the other issue.

Sir I have one question,
In UserForm user is not able to update the user details
Should I raise issue?

@github-actions github-actions bot added needs-triage question Further information is requested labels Jan 24, 2025
@Jacobjeevan
Copy link
Contributor

@rajku-dev Assigned.
Since the other PR is still open, avoid replicating the work mentioned in the other issue.

Sir I have one question, In UserForm user is not able to update the user details Should I raise issue?

No sir/madam; you can refer to us by our names.

As for not being able to update user details it depends - which user are you trying to do this with?

@Jacobjeevan Jacobjeevan removed question Further information is requested needs-triage labels Jan 24, 2025
@rajku-dev
Copy link
Contributor Author

rajku-dev commented Jan 24, 2025 •
edited
Loading

@rajku-dev Assigned.
Since the other PR is still open, avoid replicating the work mentioned in the other issue.

Sir I have one question, In UserForm user is not able to update the user details Should I raise issue?

No sir/madam; you can refer to us by our names.

As for not being able to update user details it depends - which user are you trying to do this with?

Follow this link

This block is not executed

Image

@Jacobjeevan
Copy link
Contributor

Jacobjeevan commented Jan 24, 2025 •
edited
Loading

@rajku-dev Assigned.
Since the other PR is still open, avoid replicating the work mentioned in the other issue.

Sir I have one question, In UserForm user is not able to update the user details Should I raise issue?

No sir/madam; you can refer to us by our names.
As for not being able to update user details it depends - which user are you trying to do this with?

Follow this link

This block is not executed

Image

🤔 Hmm, I think it's because the user has no role associated with that account and at present user updates require a user role specified. There's nothing you can do on the FE for it.

@rajku-dev
Copy link
Contributor Author

Yep! I think you fixed that by giving staff user role from BE.

@rajku-dev rajku-dev linked a pull request Jan 24, 2025 that will close this issue
Open
10 tasks
@rajku-dev rajku-dev mentioned this issue Jan 25, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajku-dev rajku-dev

Labels
work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhancements to Encounter Discussion/Notes | Fix Translation rajku-dev/care_fe
3 participants
@Jacobjeevan @rajku-dev @kris70lesgo