prov/efa: rxr to efa rdm round2 #9097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzamazon
force-pushed
the
efa_rxr_to_efa_rdm_round2_upstream
branch
from
d958b60
to
b384a1b
Compare
a-szegel
reviewed
Jun 30, 2023
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2019-2023 Amazon.com, Inc. or its affiliates. | |||
There was a problem hiding this comment.
Can you expand this commit message... I feel like you do a lot more in this commit than:
prov/efa: rename rxr_pkt_rx_map to efa_rdm_rxe_map
There was a problem hiding this comment.
Sure. Will add more comments
wzamazon
force-pushed
the
efa_rxr_to_efa_rdm_round2_upstream
branch
from
b384a1b
to
c698219
Compare
a-szegel
approved these changes
Jun 30, 2023
Also added a docstring for this field. Signed-off-by: Wei Zhang <[email protected]>
rxr_cq has been renamed to efa_rdm_cq in previous commits, but "rxr_cq" was used in few places. This patch fixed those occurance. Signed-off-by: Wei Zhang <[email protected]>
Signed-off-by: Wei Zhang <[email protected]>
rxr_pkt_rx_map is a hashmap between (sender address + msg_id) and RX entry. It is used in processing medium RTM and runting read RTM. This patch rename the struct to efa_rdm_rxe_map, and renamed the lookup, insert, remove function accordingly. It also move the defintion and implementation to a separate file efa_rdm_rxe_map.c/h. Signed-off-by: Wei Zhang <[email protected]>
rename rxr_get_tx/rx_pool_chunk_cnt to efa_rdm_ep_get_tx/rx_pool_size Signed-off-by: Wei Zhang <[email protected]>
Signed-off-by: Wei Zhang <[email protected]>
Signed-off-by: Wei Zhang <[email protected]>
rxr_match_info has been replaced by ofi_match_info Signed-off-by: Wei Zhang <[email protected]>
Signed-off-by: Wei Zhang <[email protected]>
This function is not used after we switch to use peer API Signed-off-by: Wei Zhang <[email protected]>
wzamazon
force-pushed
the
efa_rxr_to_efa_rdm_round2_upstream
branch
from
c698219
to
e4d7ff9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting very close