prov/efa: Check p2p support to use rdma read #10352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you need similar check for the write path? |
darrylabbate
reviewed
Sep 3, 2024
prov/efa/src/rdm/efa_rdm_msg.c
Outdated
| @@ -90,7 +90,8 @@ int efa_rdm_msg_select_rtm(struct efa_rdm_ep *efa_rdm_ep, struct efa_rdm_ope *tx | |||
|
|
|||
| if (txe->total_len >= hmem_info[iface].min_read_msg_size && | |||
| efa_rdm_interop_rdma_read(efa_rdm_ep, txe->peer) && | |||
| (txe->desc[0] || efa_is_cache_available(efa_rdm_ep_domain(efa_rdm_ep)))) | |||
| (txe->desc[0] || efa_is_cache_available(efa_rdm_ep_domain(efa_rdm_ep))) && | |||
| use_p2p) | |||
There was a problem hiding this comment.
Does it make more sense to refactor the whole conditional s.t. use_p2p is first? That way we can short-circuit and avoid the remaining (potentially expensive) logic.
shijin-aws
approved these changes
Sep 3, 2024
p2p is required for rdma read because the user buffer has to be registered to efa device. Add p2p check for subprotocols that use RDMA read. Signed-off-by: Jessie Yang <[email protected]>
darrylabbate
approved these changes
Sep 9, 2024
|
AWS CI failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p2p is required for rdma read because the user buffer has to be registered to efa device.
Add p2p check for subprotocols that use RDMA read.