Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance mode should return a 503 for easier monitoring #5

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Maintenance mode should return a 503 for easier monitoring #5

merged 1 commit into from
Mar 28, 2024

Conversation

benoit74
Copy link
Contributor

Changes:

  • return a 503 when in maintenance mode
  • does not returns anymore HTML response, but who cares ... (I failed to find how to respond an HTML response)

@benoit74 benoit74 requested a review from rgaudin March 28, 2024 08:00
@benoit74 benoit74 self-assigned this Mar 28, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (22ef910) to head (f8118f7).

Additional details and impacted files 
@@          Coverage Diff          @@
##            main      #5   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         10      10           
  Lines        599     599           
  Branches      97      97           
=====================================
  Misses       599     599

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rgaudin
rgaudin approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rgaudin rgaudin merged commit 669163c into main Mar 28, 2024
5 checks passed
@rgaudin rgaudin deleted the maintenance_503 branch March 28, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoit74 @rgaudin