Modify get_unavailable_ports to avoid KeyError: 'PublicPort' #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running CTFd in a docker host that had portainer.io running at the same time. And I got an error message containing KeyError: 'PublicPort'.
Once I looked into https://my-https-docker:2376/containers/json?all=1 I could see why the error happened.
The portainer ports looks like this:
"Ports":[
{
"IP":"0.0.0.0",
"PrivatePort":9443,
"PublicPort":9443,
"Type":"tcp"
},
{
"IP":"0.0.0.0",
"PrivatePort":8000,
"PublicPort":5080,
"Type":"tcp"
},
{
"PrivatePort":9000,
"Type":"tcp"
}.
Adding an extra check to verify that the Ports contain the key PublicPort