Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide master diff link if base branch is same as stockfish master #631

Merged

Conversation

linrock
Copy link
Contributor

@linrock linrock commented Apr 22, 2020

The master diff link now only shows up if:

  • the base branch is not the same as stockfish master
  • we don't know if the base branch is the same (old runs)

See #625 (comment)

@ppigazzini ppigazzini added enhancement gui server server side changes labels Apr 22, 2020
@ppigazzini
Copy link
Collaborator

ppigazzini commented Apr 22, 2020

When rescheduling the fields are blocked, but after pushing another test type button the master's fields are reset to default and writable.
EDIT: sorry, I posted in the wrong PR :(

@ppigazzini
Copy link
Collaborator

@linrock for very old tests it doesn't work perfectly see PROD and DEV (updated w/ with this PR)
https://tests.stockfishchess.org/tests/view/515e5f488f0c3e17002f7d64
https://dfts-0.pigazzini.it/tests/view/515e5f488f0c3e17002f7d64

@linrock
Copy link
Contributor Author

linrock commented Apr 23, 2020

@ppigazzini yep, that's expected behavior for the link to show up there, isn't it? old tests are from before we started checking the master diff server-side so there's no way to know if the base and master branch are different for those. that's why there's no message, and it's safer to leave the link there if someone wants to manually check the diff.

@ppigazzini ppigazzini merged commit 35c3e82 into official-stockfish:master Apr 23, 2020
@ppigazzini
Copy link
Collaborator

PROD updated, thank you @linrock :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement gui server server side changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants