Introduce GitHub OAuth Authentication #2132
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the long waited GitHub Auth
Allows 3 options:
1- Registering with GitHub
2- Linking your existing profile with GitHub
3- Logging in with GitHub
Instructions
Hide Sensitive Variables: Ensure
GITHUB_CLIENT_ID
andGITHUB_CLIENT_SECRET
are hidden in the configuration file.Generate GitHub OAuth Keys:
Update Configuration: Replace
GITHUB_CLIENT_ID
andGITHUB_CLIENT_SECRET
placeholders with the generated keys from GitHub.Note: this PR only concerns the Web part. I will make it happen for workers after most of the PRs gets resolved, in a final effort to get rid of the most serious issue in the framework which is the usage of plain text passwords.
Preview: