Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster worker stop on terminated task. #2128

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

vdbergh
Copy link
Contributor

@vdbergh vdbergh commented Aug 12, 2024

Instead of always waiting for the next update_task, we allow the heart beat api to stop handling a task in the worker.

@vdbergh vdbergh force-pushed the task_alive branch 3 times, most recently from ea96d84 to 8736dee Compare August 14, 2024 04:53
@vdbergh
Copy link
Contributor Author

vdbergh commented Jan 6, 2025

Rebased.

@ppigazzini ppigazzini added enhancement worker update code changes requiring a worker update labels Jan 6, 2025
Instead of always waiting for the next update_task, we allow
the heart beat api to stop handling a task in the worker.

Raise worker version to 245 (also server side).
Copy link
Collaborator

@ppigazzini ppigazzini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on DEV

@ppigazzini ppigazzini merged commit 7725b66 into official-stockfish:master Jan 7, 2025
19 checks passed
@ppigazzini
Copy link
Collaborator

ppigazzini commented Jan 7, 2025

Triggered the worker update (215 online).
EDIT: 4/5 workers updated (still 215 online).

@ppigazzini
Copy link
Collaborator

Thank you @vdbergh :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement worker update code changes requiring a worker update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants