Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cutechess command #2117

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gahtan-syarif
Copy link

@gahtan-syarif gahtan-syarif commented Jul 11, 2024

cutechess command in games.py is incorrectly formatted causing a bug where the pgn have all games with the tag ["Round 1"] . this is first spotted by @Disservin

this change is also necessary for an eventual fast-chess migration as fast-chess relies on the correct format.

@gahtan-syarif
Copy link
Author

updated the SHA

@peregrineshahin
Copy link
Contributor

One question is if this affects other stuff like the seed?, how the book is picked from, and other stuff.
If you don't mind to make sure that this is only a formatting change.

@gahtan-syarif
Copy link
Author

i will run a side by side fixed nodes test and upload the pgns here, it should result to be the same

@gahtan-syarif
Copy link
Author

new format:

cutechess-cli -recover -repeat -games 2 -rounds 233 -tournament gauntlet -pgnout newformat.pgn -site "https://tests.stockfishchess.org/tests/view/66872b0ffe7b81f5e163473c" -event "Batch 295: master vs master" -srand 12345 -resign movecount=3 score=600 -draw movenumber=34 movecount=8 score=20 -variant standard -concurrency 1 -openings file=C:\cutechess-1.3.1-win64\books\UHO_Lichess_4852_v1.epd format=epd order=random plies=16 start=52569 -engine  cmd="Stockfish dev-20240709-362a77a3.exe" name=New-ee6fc7e38b4aeef44862159215a56d97122f59a0 tc=inf nodes=5000 dir="C:/Chess Engines/" option.Hash=16 -engine name=Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 tc=inf nodes=5000 cmd="Stockfish dev-20240709-362a77a3.exe" dir="C:/Chess Engines/" option.Hash=16 -each proto=uci option.Threads=1

Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 170 - 170 - 126  [0.500] 466
...      New-ee6fc7e38b4aeef44862159215a56d97122f59a0 playing White: 95 - 75 - 63  [0.543] 233
...      New-ee6fc7e38b4aeef44862159215a56d97122f59a0 playing Black: 75 - 95 - 63  [0.457] 233
...      White vs Black: 190 - 150 - 126  [0.543] 466
Elo difference: 0.0 +/- 27.0, LOS: 50.0 %, DrawRatio: 27.0 %
SPRT: llr 0 (0.0%), lbound -inf, ubound inf

old format:

cutechess-cli -recover -repeat -games 466 -tournament gauntlet -pgnout oldformat.pgn -site "https://tests.stockfishchess.org/tests/view/66872b0ffe7b81f5e163473c" -event "Batch 295: master vs master" -srand 12345 -resign movecount=3 score=600 -draw movenumber=34 movecount=8 score=20 -variant standard -concurrency 1 -openings file=C:\cutechess-1.3.1-win64\books\UHO_Lichess_4852_v1.epd format=epd order=random plies=16 start=52569 -engine  cmd="Stockfish dev-20240709-362a77a3.exe" name=New-ee6fc7e38b4aeef44862159215a56d97122f59a0 tc=inf nodes=5000 dir="C:/Chess Engines/" option.Hash=16 -engine name=Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 tc=inf nodes=5000 cmd="Stockfish dev-20240709-362a77a3.exe" dir="C:/Chess Engines/" option.Hash=16 -each proto=uci option.Threads=1

Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 170 - 170 - 126  [0.500] 466
...      New-ee6fc7e38b4aeef44862159215a56d97122f59a0 playing White: 95 - 75 - 63  [0.543] 233
...      New-ee6fc7e38b4aeef44862159215a56d97122f59a0 playing Black: 75 - 95 - 63  [0.457] 233
...      White vs Black: 190 - 150 - 126  [0.543] 466
Elo difference: 0.0 +/- 27.0, LOS: 50.0 %, DrawRatio: 27.0 %
SPRT: llr 0 (0.0%), lbound -inf, ubound inf

@gahtan-syarif
Copy link
Author

newformat.pgn.txt
oldformat.pgn.txt

as can be seen, the resulting pgns are exactly identical except now with the new format the ["Round"] tag is properly incremented.

@vondele
Copy link
Member

vondele commented Jul 12, 2024

looks good to me.

@Disservin
Copy link
Member

first spotted by @Disservin

I don't think it was me who first noticed this.. maybe david or someone else, but w/e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants