Do not put results_info in the db. #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdbergh
force-pushed
the
format_results
branch
2 times, most recently
from
afebb4e
to
e5a6a0b
Compare
|
Rebased! |
|
Rebased. |
Rendered data does not belong in the db.
|
PROD updated, thank you @vdbergh |
|
If I'm not wrong, we can write a script to drop the Jul 04 21:25:39 ns304014 pserve[52240]: The run object 668444967a1863935cee42ba does not validate: run['results_info'] is not in the schema
Jul 04 21:28:45 ns304014 pserve[52240]: Clean_wtt_map: 105 active workers...
Jul 04 21:28:45 ns304014 pserve[52240]: Clean_wtt_map: 106 active workers...
Jul 04 21:28:45 ns304014 pserve[52240]: The run object 6685df348c84573fdb76449d does not validate: run['results_info'] is not in the schema
Jul 04 21:31:49 ns304014 pserve[52240]: Clean_wtt_map: 106 active workers...
Jul 04 21:31:49 ns304014 pserve[52240]: The run object 6684724e7a1863935cee42f9 does not validate: run['results_info'] is not in the schema |
|
Yes we can. After this PR it will just be ignored, so it would be nice to get rid of it. |
|
Ok, I will wrote a script to clean the key/value, testing it on DEV. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered data does not belong in the db.