Introduce Calculate Elo API for external use.

[peregrineshahin]

This should make it possible for external use to calculate the ELo based on Either (Ptnml or WDL) and elo0, elo1 bounds (elo_model is optional and defaults to "normalized").

The format is:
https://tests.stockfishchess.org/api/calc_elo?LL=93&LD=18711&DDWL=58877&WD=18739&WW=100&elo0=-1.75&elo1=0.25

needs testing.

[vondele]

Maybe consider renaming "DD" in "DDWL" to make clear this is not just about DD

Also, for the purpose discussed on discord, this probably should have an nginx cache enabled.

[peregrineshahin]

solved the issue of CI
by adding --trailing-comma none and formatted the code with that option.

prettier --check "server/fishtest/static/{css/*.css,html/*.html,js/*.js}" --trailing-comma none
      - name: Check linters and formatters status
        run: |
          echo "Run the following commands to format the code:"
          echo "black --exclude='env|packages' ."
          echo "isort --profile black --skip env --skip venv --skip worker/packages ."
          echo "npx prettier --write 'server/fishtest/static/{css/*.css,html/*.html,js/*.js}' --trailing-comma none"

[ppigazzini]

DEV updated.

[peregrineshahin]

DEV updated.

It works but it seems like handling errors does not work. any idea what's wrong with calling self.handle_error()

[ppigazzini]

It works but it seems like handling errors does not work. any idea what's wrong with calling self.handle_error()

-- Logs begin at Sun 2023-08-13 13:24:46 CEST, end at Sat 2023-08-19 13:18:28 CEST. --
Aug 19 13:18:20 dfts-0 pserve[30511]: 2023-08-19 13:18:20,309 ERROR [waitress][waitress-1] Exception while serving /api/calc_elo
Aug 19 13:18:20 dfts-0 pserve[30511]: Traceback (most recent call last):
Aug 19 13:18:20 dfts-0 pserve[30511]:   File "/home/usr00/fishtest/server/env/lib/python3.11/site-packages/pyramid/tweens.py", line 13, in _error_handler
Aug 19 13:18:20 dfts-0 pserve[30511]:     response = request.invoke_exception_view(exc_info)
Aug 19 13:18:20 dfts-0 pserve[30511]:                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
packages/pyramid/viewderivers.py", line 113, in _class_requestonly_view
Aug 19 13:18:20 dfts-0 pserve[30511]:     response = getattr(inst, attr)()
Aug 19 13:18:20 dfts-0 pserve[30511]:                ^^^^^^^^^^^^^^^^^^^^^
Aug 19 13:18:20 dfts-0 pserve[30511]:   File "/home/usr00/fishtest/server/fishtest/api.py", line 384, in calc_elo
Aug 19 13:18:20 dfts-0 pserve[30511]:     self.handle_error(
Aug 19 13:18:20 dfts-0 pserve[30511]:   File "/home/usr00/fishtest/server/fishtest/api.py", line 124, in handle_error
Aug 19 13:18:20 dfts-0 pserve[30511]:     error = "{}: {}".format(self.__api, error)
Aug 19 13:18:20 dfts-0 pserve[30511]:                             ^^^^^^^^^^
Aug 19 13:18:20 dfts-0 pserve[30511]: AttributeError: 'ApiView' object has no attribute '_ApiView__api'

[ppigazzini]

If I read correctly the code, self.handle_error() is a custom function used to handle an error during the validation of the worker's APIs. It depends on validate_username_password() to work:
https://github.com/glinscott/fishtest/blob/3cb76834a6cabc72ab479f13f5b74190fc1bf35e/server/fishtest/api.py#L122-L131

[peregrineshahin]

initialized the mandatory Class variables to use the function and return a 400.

[ppigazzini]

LG on DEV

[ppigazzini]

PROD updated, nginx configured to serve the route with the pserve instance on port 6545. The nginx admin should check for the nginx cache. Thank you @peregrineshahin :)