Clarify message

[vondele]

No description provided.

[vondele]

not sure what the lint CI test wants to get green.

[ppigazzini]

not sure what the lint CI test wants to get green.

The latest version of prettier must have introduced some changes, I will fix when merging.

Run prettier --check "server/fishtest/static/{css/*.css,html/*.html,js/*.js}"
Checking formatting...
[warn] server/fishtest/static/html/maintenance.html
[warn] server/fishtest/static/js/application.js
[warn] server/fishtest/static/js/calc.js
[warn] server/fishtest/static/js/live_elo.js
[warn] server/fishtest/static/js/notifications.js
[warn] server/fishtest/static/js/spsa.js
[warn] server/fishtest/static/js/toggle_password.js
[warn] Code style issues found in 7 files. Run Prettier to fix.
Error: Process completed with exit code 1.

[ppigazzini]

"Moving to the next task." is wrong

Score of New-e87e103ca9 vs Base-e87e103ca9: 46 - 49 - 79  [0.491] 174
Post request https://dfts-0.pigazzini.it:443/api/update_task handled in 176.40ms (server: 0.23ms)
The server told us that no more games are needed for this task. Moving to the next task.

Waiting for cutechess-cli to finish ... done
Uploading compressed PGN of 204640 bytes
Post request https://dfts-0.pigazzini.it:443/api/upload_pgn handled in 255.93ms (server: 19.85ms)
Task exited
Stopped by 'fish.exit' file
Waiting for the heartbeat thread to finish...
Heartbeat stopped
Deleting lock file /home/usr00/_git/__test_folder00/fishtest/worker/worker.lock

[vondele]

In that case, I don't really understand what is happening. Why would it stop by 'fish.exit' ?

[ppigazzini]

In my opinion, the log of a step should have the information about the context of that step, and not about the context of the next step as well:

• we can have several possible next step, depending on certain conditions (if the current step is not the final one)
• the next step could change in the time due to changes of the workflow logic

I used fish.exit to signal to the worker to exit after completing the current task, to expose the contraindication of logging the context of the next step.

By the way the second half of the message is confusing with the "normal" workflow as well, because the next steps are about completing the task (right now: waiting cutechess finishing, uploading the pgn), not moving to the next task (whatever "moving" means).

Finished game 173 (New-e87e103ca9 vs Base-e87e103ca9): 0-1 {Black wins by adjudication}
Score of New-e87e103ca9 vs Base-e87e103ca9: 42 - 55 - 77  [0.463] 174
Post request https://dfts-0.pigazzini.it:443/api/update_task handled in 306.23ms (server: 0.40ms)
The server told us that no more games are needed for this task. Moving to the next task.

Waiting for cutechess-cli to finish ... done
Uploading compressed PGN of 215940 bytes
Post request https://dfts-0.pigazzini.it:443/api/upload_pgn handled in 209.00ms (server: 10.00ms)
Task exited
Current time is 2023-07-06 09:43:57.866795 UTC (local offset: +02:00)
Verify worker version...
Post request https://dfts-0.pigazzini.it:443/api/request_version handled in 135.16ms (server: 0.12ms)
Remaining number of github api calls = 60
Fetching task...
Post request https://dfts-0.pigazzini.it:443/api/request_task handled in 156.69ms (server: 29.01ms)
Working on task 2 from https://dfts-0.pigazzini.it:443/tests/view/64a679c5737415a36e9a5ca1

[vondele]

Updated based on the feedback.

[ppigazzini]

PROD updated to trigger the worker update, thnak you @vondele :)