If verification search fails low, return beta #5262
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same bench as master:
bench: 1441794
The original code checks if v >= beta after the verification search. However, if the verification search fails low (v < beta), it still returns nullValue.
With this change, if we can't beat beta, we return v, so we don't completly render the verification search useless.
Passed STC:
LLR: 2.93 (-2.94,2.94) <0.00,2.00>
Total: 675040 W: 173934 L: 172755 D: 328351
Ptnml(0-2): 1813, 70154, 192463, 71221, 1869
https://tests.stockfishchess.org/tests/view/664739006dcff0d1d6b05cb9
*Let me know if an LTC test is needed.
bench: 1441794