Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert moveCountPruning alleged speedup #5213

Closed
wants to merge 1 commit into from

Conversation

FauziAkram
Copy link
Contributor

Non-Functional simplification, reverting #4823 which probably was a fluke, as many other devs theorized over time.

As it was originally tested with only an stc test, for now I ran only an stc non-reg test.
However, if an LTC is required/preferred please let me know.

Passed stc:
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 88992 W: 22779 L: 22633 D: 43580
Ptnml(0-2): 137, 8706, 26681, 8818, 154
https://tests.stockfishchess.org/tests/view/6636c4844b68b70d85800dae

bench: 1480008

bench: 1480008
@mstembera
Copy link
Contributor

But why? It clearly avoids unnecessary calls to futility_move_count() even if they are not significant enough to fail non regression bounds. It also makes it nice and obvious that once moveCountPruning is true it stays true. I could perhaps see writing
moveCountPruning = moveCountPruning || moveCount >= futility_move_count(improving, depth); to avoid the branch. Just my 2 cents.

@MinetaS
Copy link
Contributor

MinetaS commented May 5, 2024

I think the correct way to prove whether a speedup test is fluke or not, is to repeat the same test again with regular bounds, not with non regression bounds.

Not saying this is not a simplification, but as you mentioned the possibility of fluke, just giving my opinion about it.

@vondele vondele added simplification A simplification patch to be merged Will be merged shortly labels May 9, 2024
@vondele vondele closed this in 9d6dab0 May 9, 2024
@mstembera
Copy link
Contributor

Just for tracking purposes https://tests.stockfishchess.org/tests/view/6649837bb8fa20e74c39f456 finished yellow +0.46elo after 700K games.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simplification A simplification patch to be merged Will be merged shortly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants