add asserts, move to types.h

src/search.h

@@ -55,10 +55,6 @@ class TranspositionTable;
 class ThreadPool;
 class OptionsMap;
 
-constexpr bool is_win(Value value) { return value >= VALUE_TB_WIN_IN_MAX_PLY; };
-constexpr bool is_loss(Value value) { return value <= VALUE_TB_LOSS_IN_MAX_PLY; }
-constexpr bool is_win_or_loss(Value value) { return is_win(value) || is_loss(value); }
-
 namespace Search {
 
 // Stack struct keeps track of the information we need to remember from nodes

src/types.h

@@ -155,6 +155,19 @@ constexpr Value VALUE_TB                 = VALUE_MATE_IN_MAX_PLY - 1;
 constexpr Value VALUE_TB_WIN_IN_MAX_PLY  = VALUE_TB - MAX_PLY;
 constexpr Value VALUE_TB_LOSS_IN_MAX_PLY = -VALUE_TB_WIN_IN_MAX_PLY;
 
+
+constexpr bool is_win(Value value) {
+    assert(value <= VALUE_MATE);
+    return value >= VALUE_TB_WIN_IN_MAX_PLY;
+}
+
+constexpr bool is_loss(Value value) {
+    assert(value >= -VALUE_MATE);
+    return value <= VALUE_TB_LOSS_IN_MAX_PLY;
+}
+
+constexpr bool is_win_or_loss(Value value) { return is_win(value) || is_loss(value); }
+
 // In the code, we make the assumption that these values
 // are such that non_pawn_material() can be used to uniquely
 // identify the material on the board.