Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stop-containers-during-backup.md #538

Closed
wants to merge 1 commit into from
Closed

Conversation

jastlw
Copy link

@jastlw jastlw commented Feb 21, 2025

Read-only for /var/run/docker.sock:/var/run/docker.sock is wrong. Otherwise, a stop of different containers may not be possible.

Here is it all right: https://offen.github.io/docker-volume-backup/recipes/#using-mariadb-dumpmysqldump-to-prepare-the-backup

Read-only for /var/run/docker.sock:/var/run/docker.sock is wrong.
Otherwise, a stop of different containers may not be possible.

Here is it all right: https://offen.github.io/docker-volume-backup/recipes/#using-mariadb-dumpmysqldump-to-prepare-the-backup
@m90
Copy link
Member

m90 commented Feb 22, 2025

Could you share further details about the setup where mounting the socket in readonly mode creates failures for you? I just tried running the tests using :ro for the socket and restarting containers and scaling services still worked as expected.

@m90
Copy link
Member

m90 commented Feb 26, 2025

I migrated the entire test suite to use :ro mounts for sockets in #546 and everything passes as expected, which means there must be something special about your setup. Can you share a. the configuration you use and b. the error you are encountering?

@jastlw
Copy link
Author

jastlw commented Feb 27, 2025

@m90 Thanks for testing and all the work you have done. 😍

I think you are right: I want to execute the docker-volume-backup from a remote machine. Therefore I bound the docker socket over sshfs. There were some faults.
Sorry for the trouble.

You could think about to also make it here only ro: https://offen.github.io/docker-volume-backup/recipes/#using-mariadb-dumpmysqldump-to-prepare-the-backup

@jastlw jastlw closed this Feb 27, 2025
@m90
Copy link
Member

m90 commented Feb 27, 2025

Updated the docs to always use :ro in d8ac5ae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants