Fix/add custom attributes link #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for fixing this. You might want to add you name to AUTHORS.rst and CITATION.cff. |
|
What do we do about |
p-snft
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
This implements a pass-through for functionality that is proposed in oemof.network. As all other classes already implement it the same way, it's okay to have it here for consistency. (As the functionality is not implemented, I also do not see a way how to properly test this, so the decreasing coverage should be okay this time.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the Link component gets the argument
custom_attributes.Issue | Because I can't create an issue - here's the description:
The link component is missing the argument
custom_attributesin its class.I've discovered this using the link component in oemof-tabular. During the postprocessing I've been losing the
type = 'link'. Instead it was set to None. This is due to these lines wherekwargs_unexpectedare lost if the component does not have the argument "custom_attributes".Local system and env info