Rename custom_attributes to custom_properties for Nodes #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the oemof.network.Node.custom_properties using an argument called "custom_attributes" was rather confusing. Additionally, the class Bus already called the argument "custom_properties".
|
I think this is fixing an inconsistency and adapting is rather easy. Thus, I feel like we might skip having transitional wrappers. |
# Conflicts: # docs/whatsnew/v0-6-0.rst
|
I asked for feedback two weeks ago. As nobody objected, I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the
oemof.network.Node.custom_propertiesusing an argument calledcustom_attributeswas rather confusing. Additionally, the class Bus already called the argumentcustom_properties.