Add information to namedtuple tutorial #1095
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokochems
requested changes
Nov 22, 2024
There was a problem hiding this comment.
Thanks a lot for opening this pull request. However, I think, it requires some adaptions:
- Most importantly, we should have a cleaned version without any execution output.
- Besides, I think some changes are not necessary, such as spreading markdown explanations across multiple cells.
| @@ -12,7 +12,7 @@ | |||
| "cell_type": "markdown", | |||
| "metadata": {}, | |||
| "source": [ | |||
| "We want to model a group of buildings, each with demands for electricity and space heating.\n", | |||
| "We want to model a group of buildings, each with demands for electricity and space heating. \n", | |||
There was a problem hiding this comment.
In my view, the space is not needed as there is the line break.
Comment on lines
+25
to
+30
| ] | ||
| }, | ||
| { | ||
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ |
There was a problem hiding this comment.
I don't see the necessity to add another markdown cell. Instead, I'd suggest to add the text to the above cell.
Comment on lines
-32
to
+65
| "execution_count": null, | ||
| "execution_count": 2, |
There was a problem hiding this comment.
We should host a cleaned up version, not showing any execution results.
| "source": [ | ||
| "import networkx as nx\n", | ||
| "from oemof.network.graph import create_nx_graph\n", | ||
| "\n", | ||
| "graph = create_nx_graph(energy_system)\n", | ||
| "\n", | ||
| "nx.draw(graph, with_labels=True, font_size=8)" | ||
| "nx.draw(graph, with_labels=True, font_size=7)" |
There was a problem hiding this comment.
Is there a reasoning to alter the font_size attribute?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in feature/data_analysis_tutorial