Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/37 guest can see released #39

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Feature/37 guest can see released #39

wants to merge 5 commits into from

Conversation

sunday00
Copy link
Contributor

@sunday00 sunday00 commented Sep 15, 2023 •
edited
Loading

๐Ÿ“ ๊ฐœ์š”

๋น„๋กœ๊ทธ์ธ ์œ ์ € ์• ๋‹ˆ๋ฉ”์ด์…˜ ์กฐํšŒ ๊ฐ€๋Šฅ
์žฅ๋ฅด ์œ ์—ฐ์„ฑ ํ™•๋ณด
์‹œ์ฆŒ ์ปฌ๋Ÿผํ™”
์‹œ๋ฆฌ์ฆˆ๊ทธ๋ฃน์ปฌ๋Ÿผ ์ถ”๊ฐ€

๐Ÿš€ ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • @user ์— guest role ์ถ”๊ฐ€
  • ์• ๋‹ˆ๋ฉ”์ด์…˜ list / show ์— guard ์ œ๊ฑฐ
  • admin role ๊ตฌ๋ถ„ released ํ•„ํ„ฐ๋ง
  • ์žฅ๋ฅด ํƒ€์ž… enum์„ ํ๊ธฐํ•˜๊ณ  name string์œผ๋กœ ์ถ”๊ฐ€๊ฐ€ ์‰ฝ๊ฒŒ ๋ณ€๊ฒฝ
  • ์‹œ์ฆŒ ํ…Œ์ด๋ธ” ์‚ญ์ œ
  • ์• ๋‹ˆ๋ฉ”์ด์…˜ ํ•„๋“œ๋กœ seasonYear, seasonQuarter ์ถ”๊ฐ€
  • seriesGroup ์ถ”๊ฐ€
  • ์ถ”ํ›„ ์‹œ๋ฆฌ์ฆˆ ๋ฌถ๋Š” ์šฉ๋„
  • list๊ฒ€์ƒ‰์‹œ seariseGroup๋„ ๊ฒ€์ƒ‰

๐Ÿ”— ๊ด€๋ จ ์ด์Šˆ

  • ์ด feat๋Š” ๋‹ค๋ฅธ ๊ธฐ๋Šฅ ๊ตฌํ˜„์ค‘ ๊ธด๊ธ‰์ฒ˜๋ฆฌ commit ์ž…๋‹ˆ๋‹ค.
  • ์Šคํ‚ค๋งˆ ๋ณ€๊ฒฝ์ด ๊ฝค ๋“ค์–ด๊ฐ”์Šต๋‹ˆ๋‹ค.
    • npm run migrate:dev ํ•„์š”
    • ํ˜„์žฌ db ์ƒํƒœ์— ๋”ฐ๋ผ ๋ฐ์ดํ„ฐ ์žฌ์‚ฝ์ž… ํ•„์š”ํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

โž• ๊ธฐํƒ€

@FaberJoo FaberJoo requested review from FaberJoo and removed request for yunhozz September 27, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FaberJoo FaberJoo Awaiting requested review from FaberJoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunday00 @FaberJoo @sunday00tdi