Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue-3133): include logged in user scenario #3156

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

jeyren95
Copy link
Contributor

@jeyren95 jeyren95 commented Feb 20, 2024

Player profile is public if:

  1. Player is a pro player
  2. Player's match history is not disabled (i.e. "fh_unavailable" is false)
  3. Player's match history is disabled, but the player is logged in and is viewing own profile

Player profile is private for all other scenarios. It is much easier to just check if the player profile is public, since there seems to be fewer + less complicated scenarios

Do let me know if I have missed out on any scenarios!

image
^ this is how it will look like if we don't hide the W/L stat

@howardchung
Copy link
Member

This seems fine. Although it's probably cleaner to return the visibility from the backend so we're not implementing this logic twice.

@howardchung howardchung merged commit 08e8019 into odota:master Mar 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants