[WIP] Notifications for new matches #1657
Conversation
| } | ||
| return cb(err, match.match_id); | ||
| }); | ||
| } | ||
|
|
||
| function sendNotifications(match) { |
There was a problem hiding this comment.
you probably have to check the origin of the parse request and do this for scanner only (similar to what was done for scenarios), otherwise, people requesting parses might cause multiple notifications?
There was a problem hiding this comment.
https://github.com/odota/core/blob/master/svc/parser.js#L39
you could add something like doNotifications as a property on the match, or just check directly
| return next(); | ||
| }); | ||
|
|
||
| notifications.route('/') |
There was a problem hiding this comment.
It's used to store the notification token on the server so that we know who to send notifications to.
| @@ -61,9 +61,34 @@ function parseProcessor(job, cb) { | |||
| console.error(err.stack || err); | |||
| } else { | |||
| console.log('completed parse of match %s', match.match_id); | |||
| sendNotifications(match); | |||
There was a problem hiding this comment.
I think we should make this only enabled if a config option is set. probably there are people using this that don't need this feature
No description provided.