🎨 refactor: move getConstants and getConstantsByResource route handle…

…r to database module
odota · Sep 15, 2023 · 463a87a · 463a87a
1 parent 9db9772
commit 463a87a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 10 deletions.
diff --git a/routes/handlers/database.js b/routes/handlers/database.js
@@ -71,6 +71,18 @@ function getReplayData(req, res, cb) {
     });
 }
 
+function getConstants(req, res) {
+  return res.json(Object.keys(constants));
+}
+
+function getConstantsByResource(req, res, cb) {
+  const { resource } = req.params;
+  if (resource in constants) {
+    return res.json(constants[resource]);
+  }
+  return cb();
+}
+
 function getRecordsByField(req, res, cb) {
   redis.zrevrange(`records:${req.params.field}`, 0, 99, "WITHSCORES", (err, rows) => {
     if (err) {
@@ -177,6 +189,8 @@ function getHealth(req, res, cb) {
 
 module.exports = {
   explorer,
+  getConstants,
+  getConstantsByResource,
   getSchema,
   getHealth,
   getMmrDistributions,

diff --git a/routes/spec.js b/routes/spec.js
@@ -1690,13 +1690,7 @@ The OpenDota API offers 50,000 free calls per month and a rate limit of 60 reque
           },
         },
         route: () => "/constants/:resource?",
-        func: (req, res, cb) => {
-          const { resource } = req.params;
-          if (resource in constants) {
-            return res.json(constants[resource]);
-          }
-          return cb();
-        },
+        func: databaseHandler.getConstantsByResource,
       },
     },
     "/constants": {
@@ -1723,9 +1717,7 @@ The OpenDota API offers 50,000 free calls per month and a rate limit of 60 reque
           },
         },
         route: () => "/constants",
-        func: (req, res) => {
-          return res.json(Object.keys(constants));
-        },
+        func: databaseHandler.getConstants,
       },
     },
   },