[IMP] util/records: skip replace if all ids are the same #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
KangOl
reviewed
Apr 14, 2025
src/util/records.py
Outdated
Comment on lines
1472
to
1474
| if not id_mapping: | ||
| if not id_mapping: | ||
| _logger.warning("Nothing to replace in model `%s`, ignoring empty mapping", model_src) |
There was a problem hiding this comment.
Suggested change
| if not id_mapping: | |
| if not id_mapping: | |
| _logger.warning("Nothing to replace in model `%s`, ignoring empty mapping", model_src) | |
| if not id_mapping: | |
| if not id_mapping: | |
| if not id_mapping: | |
| _logger.warning("Nothing to replace in model `%s`, ignoring empty mapping", model_src) |
There was a problem hiding this comment.
rebase mishap :/
If all ids are the same and we are replacing in the same model we
currently cause an error. This is not necessary and could lead to false
errors if the list of mapping ids is correctly the same.
For example sometimes we transform a model A into model B by updating
metadata. Then we insert into B's table, and finally perform a replace
of references from A's table to B's table. This would fail if the ids
are the same. This case will happen with a high probability if there is
only one A record with id=1 since the single B record would get id=1 as
well.
Example logs after the patch:
```
2025-04-14 07:28:32,883 42811 WARNING test_16 odoo.upgrade.util.records: Replace references in model `res.country`, ignoring same-id mapping `{1: 1, 2: 2}`
2025-04-14 07:28:32,883 42811 WARNING test_16 odoo.upgrade.util.records: Nothing to replace in model `res.country`, ignoring empty mapping
```
aj-fuentes
force-pushed
the
master-imp_avoid_error-afu
branch
from
283d018 to
133d859
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all ids are the same and we are replacing in the same model we
currently cause an error. This is not necessary and could lead to false
errors if the list of mapping ids is correctly the same.
For example sometimes we transform a model A into model B by updating
metadata. Then we insert into B's table, and finally perform a replace
of references from A's table to B's table. This would fail if the ids
are the same. This case will happen with a high probability if there is
only one A record with id=1 since the single B record would get id=1 as
well.
Example logs after the patch: