[FIX] runbot: fix branch search #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-fence
reviewed
Jan 15, 2025
runbot/models/branch.py
Outdated
| return ['&', ('remote_id', '=', self.env['runbot.remote'].search([('owner', '=', owner), ('repo_name', '=', repo_name)]).id), ('name', operator, branch_name)] | ||
| # Match format (owner?, repo, branch) | ||
| owner = repo = branch = None | ||
| if (m := re.match(r'(?:([\w-]+)/)?([\w-]+):([\w-]+)', value)): |
There was a problem hiding this comment.
Suggested change
| if (m := re.match(r'(?:([\w-]+)/)?([\w-]+):([\w-]+)', value)): | |
| if (m := re.match(r'(?:([\w-]+)/)?([\w-]+):([\w\.-]+)', value)): |
Branch names may contains . otherwise, searching for a branch with odoo:17.0-fix-too will lead to a ilike %17%
There was a problem hiding this comment.
Good catch 😄
Williambraecky
force-pushed
the
18.0-fix-branch-dname-search-wbr
branch
from
d4fd0a6 to
fae4957
Compare
|
@d-fence I also added tests to match the new behavior :) |
Allows searching branch through pr url or full branch name. Also fixes a crash when searching invalid values.
Williambraecky
force-pushed
the
18.0-fix-branch-dname-search-wbr
branch
from
fae4957 to
f95c2be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows searching branch through pr url or full branch name. Also fixes a crash when searching invalid values.