[PERF] runbot: remove row_number queries #1008
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Xavier-Do would be worth it to run an explain (analyse) on those queries on prod/mirror just to check if it saves any time at all. |
Xavier-Do
reviewed
Dec 5, 2024
| for batch in batchs: | ||
| batch_ids[batch.bundle_id.id].append(batch.id) | ||
|
|
||
| SELECT bundle.id, ARRAY_AGG(batch.id) |
There was a problem hiding this comment.
Similar in perfs to the previous, except with create index runbot_batch__bundle_id_id_desc_index on runbot_batch (bundle_id, id desc); Blazing fast !!!!!!
Williambraecky
force-pushed
the
17.0-remove-row-number-wbr
branch
2 times, most recently
from
b91b827 to
10001bc
Compare
The row_number window function is quite unoptimized as it requires reading the whole table. Using lateral join and / or distinct makes better use of existing indexes.
Williambraecky
force-pushed
the
17.0-remove-row-number-wbr
branch
from
10001bc to
b659c73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The row_number window function is quite unoptimized as it requires reading the whole table.
Using lateral join and / or distinct makes better use of existing indexes.