Skip to content

Commit

Permalink
[FIX] theme_odoo_experts: remove unused configurator snippets
Browse files Browse the repository at this point in the history
Currently, an error occurs while importing an 'Experts' theme template.

Steps to produce:

- Install the 'website' module.
- Build one website, try to switch its theme to the 'Experts' theme.

ValueError:
External ID not found in the system: website.configurator_s_picture

When switching a website theme to the 'Experts' theme, an error occurs
during importing their XML definition because their parent template does
not exist. To resolve this issue we can remove this template.

Indeed, that configurator snippet override was not needed anymore since
the 'Experts' theme was not using that specific snippet for their
configurator pages anymore. The error went unnoticed because on runbot
all themes are installed, and at least one of them was using that
specific snippet in a configurator page. This will be improved.

See [1] with the same kind of issue.

[1]: aed6d05

Sentry-5962594281

closes #990

X-original-commit: 6336bbd
Signed-off-by: Quentin Smetz (qsm) <[email protected]>
  • Loading branch information
mega-odoo authored and qsm-odoo committed Oct 16, 2024
1 parent 3776161 commit d9af188
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions theme_odoo_experts/views/snippets/s_picture.xml
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,4 @@
<xpath expr="//figcaption" position="replace"/>
</template>

<template id="configurator_s_picture" inherit_id="website.configurator_s_picture">
<!-- Shape option -->
<xpath expr="//section" position="attributes">
<attribute name="data-oe-shape-data">{"shape":"web_editor/Wavy/08","flip":["y"]}</attribute>
</xpath>
<!-- Shape -->
<xpath expr="//div[hasclass('o_container_small')]" position="before">
<div class="o_we_shape o_web_editor_Wavy_08" style="background-image: url('/web_editor/shape/web_editor/Wavy/08.svg?c2=o-color-3&amp;flip=y'); background-position: 50% 100%;"/>
</xpath>
</template>

</odoo>

0 comments on commit d9af188

Please sign in to comment.