add a time-to-RFC3339 conversion function #4281

c-cube · 2024-09-21T04:49:52Z

No description provided.

this is the counterpart to the existing parsing function `rfc3339_to_time_utc` and others. It prints the timestamp as a string, allocated dynamically.

core/time/rfc3339.odin

tests/core/time/test_core_time.odin

core/time/rfc3339.odin

Co-authored-by: flysand7 <[email protected]>

Kelimion · 2024-09-22T02:25:54Z

We run our tests with -vet -strict-style. The CI is complaining that you've shadowed the offset parameter.

D:/a/Odin/Odin/core/time/rfc3339.odin(279:3) Error: Declaration of 'utc_offset' shadows declaration at line 201 
	utc_offset := abs(utc_offset) 
	^

I would rename the offset you're using to keep track of where you are in the buffer to index or idx. Then you can write offset := abs(utc_offset) and use that for the TZ.

Alternatively you could write utc_offset := utc_offset at the top of the procedure to let the compiler know you're intentionally shadowing what is otherwise an immutable parameter.

c-cube · 2024-09-22T04:08:15Z

Thank you, I took the second option.

c-cube added 2 commits September 21, 2024 00:47

add time.time_to_rfc3339, a printer to RFC3339 dates

a89d22b

this is the counterpart to the existing parsing function `rfc3339_to_time_utc` and others. It prints the timestamp as a string, allocated dynamically.

add tests for time.time_to_rfc3339

d08b3d3