Apply suggestions from code review

Co-authored-by: flysand7 <[email protected]>
odin-lang · Sep 22, 2024 · 32e13f1 · 32e13f1
1 parent d08b3d3
commit 32e13f1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/core/time/rfc3339.odin b/core/time/rfc3339.odin
@@ -204,8 +204,8 @@ time_to_rfc3339 :: proc(time: Time, utc_offset : int = 0, include_nanos := true,
 
 	if datetime.year < 0 || datetime.year >= 10_000 { return "", false }
 
-	temp_string := [30]u8{}
-	offset : uint = 0 // offset in temp_string
+	temp_string := [36]u8{}
+	offset : uint = 0
 
 	print_as_fixed_int :: proc(dst: []u8, offset: ^uint, width: i8, i: i64) {
 		i := i
@@ -275,7 +275,7 @@ time_to_rfc3339 :: proc(time: Time, utc_offset : int = 0, include_nanos := true,
 		offset += 1
 	} else {
 		temp_string[offset] = utc_offset > 0 ? '+' : '-'
-		offset += 1;
+		offset += 1
 		utc_offset := abs(utc_offset)
 		print_as_fixed_int(temp_string[:], &offset, 2, i64(utc_offset / 60))
 		temp_string[offset] = ':'

diff --git a/tests/core/time/test_core_time.odin b/tests/core/time/test_core_time.odin
@@ -201,7 +201,7 @@ test_print_rfc3339 :: proc(t: ^testing.T) {
 	TestCase :: struct {
 		printed: string,
 		time: i64,
-		utc_offset: int
+		utc_offset: int,
 	};
 
 	tests :: [?]TestCase {
@@ -221,7 +221,8 @@ test_print_rfc3339 :: proc(t: ^testing.T) {
 
 		testing.expectf(
 			t, printed_timestamp == test.printed,
-			"expected is %w, printed is %w", test.printed, printed_timestamp)
+			"expected is %w, printed is %w", test.printed, printed_timestamp,
+		)
 	}
 }